Generalize UFS atmospheric component. Bring in MPAS dycore. #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture for CCPP. More CMake modifications
…ture/mpas-dycore-reorg
Reorganize code for MPAS dycore. Isolate FV3 and MPAS pieces.
14 tasks
climbfuji
reviewed
Oct 9, 2024
There was a problem hiding this comment.
This is just a quick first pass through the PR with a few small typos/issues I found. I am not sure where the best place is to provide more general feedback on this PR, the ufs-weather-model PR, etc.
I'll post something in respons to the ufs-community/ufs-weather-model PR so that it is more visible to NOAA UFS folks, including those that don't follow the FV3ATM repo.
There was a problem hiding this comment.
This submodule pointer update seems invalid
| METADATA_HTML_OUTPUT_DIR = '{build_dir}/physics/physics/docs' | ||
|
|
||
| # HTML document containing the model-defined CCPP variables | ||
| HTML_VARTABLE_FILE = '{build_dir}/physics/CCPP_VARIABLES_FV3.html' |
There was a problem hiding this comment.
Suggested change
| HTML_VARTABLE_FILE = '{build_dir}/physics/CCPP_VARIABLES_FV3.html' | |
| HTML_VARTABLE_FILE = '{build_dir}/physics/CCPP_VARIABLES_MPAS.html' |
? or UFS?
| HTML_VARTABLE_FILE = '{build_dir}/physics/CCPP_VARIABLES_FV3.html' | ||
|
|
||
| # LaTeX document containing the provided vs requested CCPP variables | ||
| LATEX_VARTABLE_FILE = '{build_dir}/framework/doc/DevelopersGuide/CCPP_VARIABLES_FV3.tex' |
There was a problem hiding this comment.
Suggested change
| LATEX_VARTABLE_FILE = '{build_dir}/framework/doc/DevelopersGuide/CCPP_VARIABLES_FV3.tex' | |
| LATEX_VARTABLE_FILE = '{build_dir}/framework/doc/DevelopersGuide/CCPP_VARIABLES_MPAS.tex' |
? or UFS?
|
Moving this to DRAFT for the time being. |
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains changes to generalize atmospheric component of the UFS Weather Model:
Refactor the CMakeLists to build an atmospheric component with either an FV3
or MPAS dynamical core.
Add CMakeLists.txt to build MPAS core_atmosphere component. The CMake recipes from the "MPAS atmospheric core" were adapted to work in the UFS build system.
Modify CCPP physics CmakeLists.txt to build independent MPAS/FV3 couplings to the physics.
Create "stub" mpas infrastructure. This includes stubs for the MPAS atmospheric component driver and overlaying NUOPC cap.
With these changes, the MPAS dynamical core builds within UFS.
Next steps, build atmospheric driver for MPAS, which includes creating new typedefs for coupling between the CCPP and MPAS.
Issue(s) addressed
N/A
Testing
Tested on Hera using Intel.
All UFS regression tests pass, see /scratch1/BMC/gmtb/Dustin.Swales/UFS/MPAS/ufs-weather-model/tests/logs/RegressionTests_hera.log
There is a new test in tests/rt.conf to build the MPAS dynamical core (just build, no run)
Dependencies
This PR introduces a new submodule to the UFS atmosphere, the MPAS-Model. A forked copy of the authoritative MPAS-Model has been created under the ufs-community GitHub organization.
Requirements before merging
N/A